You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have not tested that this actually sleeps correctly, or that ryujinx can be restored correctly.
I just debugged and queried that the thread execution state is set correctly via SetThreadExecutionState(0).
Please leave a comment if you test it and it works as intended (Can sleep and wake up fine while paused).
Ran into an issue since AppHost.cs Pause/Resume are called from the "Main Thread" (The one running Program.Main and the WndProc) and the thread that currently calls DisplayState Restore/Prevent is another one (The one running AppHost.MainLoop).
I just put all DisplayState calls within a Dispatcher.UIThread.Post delegate (It was not needed for the ones called from Resume/Pause in my tests but I added them just in case).
I considered adding a private method on AppHost that handles that but since it's only used twice per method I wasn't sure if it was worth it.
No, this doesn't work.
We can debug this by use command powercfg /requests to find out what prevent system fall in to sleep. And in this build, the audio streaming is in used even game is paused. But I have no idea why monitor cannot turn off even command reported nothing prevent system turn off display.
I think it's coming from SDL2 audio . I've tried both the SDL_HINT_VIDEO_ALLOW_SCREENSAVER hint and SDL_PauseAudioDevice and neither seems to prevent this from happening. I don't know if destroying and recreating the sdl audio devices/sessions would be an acceptable solution here (Seems a bit heavy handed).
I asked about it in an SDL discord server and a maintainer told me to report it, which I did in libsdl-org/SDL#9601
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6703
I have not tested that this actually sleeps correctly, or that ryujinx can be restored correctly.
I just debugged and queried that the thread execution state is set correctly via
SetThreadExecutionState(0).Please leave a comment if you test it and it works as intended (Can sleep and wake up fine while paused).
Ran into an issue since AppHost.cs Pause/Resume are called from the "Main Thread" (The one running Program.Main and the WndProc) and the thread that currently calls DisplayState Restore/Prevent is another one (The one running AppHost.MainLoop).
I just put all DisplayState calls within a
Dispatcher.UIThread.Postdelegate (It was not needed for the ones called from Resume/Pause in my tests but I added them just in case).I considered adding a private method on AppHost that handles that but since it's only used twice per method I wasn't sure if it was worth it.