Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog in About window #6677

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

yell0wsuit
Copy link
Contributor

@yell0wsuit yell0wsuit commented Apr 18, 2024

image

Add changelog button in the about window--allow quick looking at the version history (10 most recent) without opening GitHub.

Closes #3262--while in the issue says adding a section for changelog, it would make the about dialog look cluttered. So IMO adding a button to open the changelog window seems better.

@github-actions github-actions bot added gui Related to Ryujinx.Ui infra Related to the project infrastructure labels Apr 18, 2024
@ryujinx-mako ryujinx-mako bot requested review from AcK77, emmauss, TSRBerry and a team April 18, 2024 13:48
@yell0wsuit yell0wsuit changed the title Add changelog window in About Add changelog in About window Apr 18, 2024
@gdkchan
Copy link
Member

gdkchan commented Apr 18, 2024

Before implementing something like this, I think we need to automate changelogs. Right now someone has to write it manually after a new version is released, which depends on availability and may take a few minutes, hours or days. That would make the process rather inconsistent as sometimes you would receive the update prompt without a changelog for the latest version.

The second change we need is an easier way to fetch the changelogs, like a json with all the information neatly serialised for the emulator to consume. Using HTML scraping to extract it from the GitHub wiki page is not a good approach.

@Rafacasari
Copy link

The second change we need is an easier way to fetch the changelogs, like a json with all the information neatly serialised for the emulator to consume. Using HTML scraping to extract it from the GitHub wiki page is not a good approach.

Maybe using GitHub Tags API to get commits urls and then get the commit message from each tag (like this one)? (ofc it would need some basic regex to remove people e-mail from the message)

And then always make sure to add commit messages properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Related to Ryujinx.Ui infra Related to the project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Adding Changelog to About Page in-app
3 participants