New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ava UI: Settings UI Jank Fixes #6673
Draft
IsaacMarovitz
wants to merge
30
commits into
Ryujinx:master
Choose a base branch
from
IsaacMarovitz:input-ui-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacMarovitz
force-pushed
the
input-ui-fixes
branch
5 times, most recently
from
April 23, 2024 01:50
7c3bb92
to
6d6c179
Compare
IsaacMarovitz
force-pushed
the
input-ui-fixes
branch
from
April 27, 2024 15:46
6d6c179
to
932653d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ContentDialogHelper
to work on windows other than the main window. Previously, any dialogues triggered by settings would awkwardly springboard the user back to the main window, leaving the settings window open in the background. Now, these dialogues will appear on the settings window itself.Apply
button is only available if current configuration is dirty.ConfigurationState
until the user saves, as opposed to the previous system that 'reverted' by reloading the config from disk.Handheld
will be removed from the players list in docked mode.Esc
andEnter
shortcuts for the window close buttons are now disabled when we are waiting for a new key to bind. This should allow users to bindEnter
.Esc
is still reserved and, therefore, unbindable.SettingsViewModel
has been split into several smaller view models. This is more in line with MVVM architecture and makes the code clearer and easier to read at a glance.SettingsViewModel
depends on these sub-VMs.SettingsViewModel
handles saving the updated config to disk.Closes #6395.