Refactor & modularize code in Updater.cs #6670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache httpClient and remove ConstructHttpClient()
Replace `WebClient` with `HttpClient`, plus updating DoUpdateWithSingleThreadWorker and DoUpdateWithMultipleThreads
This is just for testing the update functionality!
Since Memory<byte> is initialized with a fixed size, `.Slice(0, readSize)` and `.Slice(0, bytesRead)` are necessary to ensure that only the part of the buffer that contains data is written to the file stream. So IDE0057 is not appropriate in this context.
AcK77
requested changes
May 15, 2024
Comment on lines
+24
to
+25
| private static long _buildSize; | ||
| private const int ConnectionCount = 4; |
There was a problem hiding this comment.
Suggested change
| private static long _buildSize; | |
| private const int ConnectionCount = 4; | |
| private const int ConnectionCount = 4; | |
| private static long _buildSize; |
| int completedRequests = 0; | ||
| int[] progressPercentage = new int[ConnectionCount]; | ||
| List<byte[]> chunkDataList = new List<byte[]>(new byte[ConnectionCount][]); | ||
|
|
| Buffer.BlockCopy(chunk, 0, data, (int)position, chunk.Length); | ||
| position += chunk.Length; | ||
| } | ||
| return data; |
There was a problem hiding this comment.
Suggested change
| return data; | |
| return data; |
| { | ||
| internal static partial class Updater | ||
| { | ||
|
|
| await ContentDialogHelper.CreateWarningDialog( | ||
| LocaleManager.Instance[LocaleKeys.DialogUpdaterConvertFailedMessage], | ||
| LocaleManager.Instance[LocaleKeys.DialogUpdaterCancelUpdateMessage]); | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| return null; | |
| return null; |
| LocaleManager.Instance[LocaleKeys.DialogUpdaterConvertFailedGithubMessage], | ||
| LocaleManager.Instance[LocaleKeys.DialogUpdaterCancelUpdateMessage]); | ||
| _running = false; | ||
| return false; |
There was a problem hiding this comment.
Suggested change
| return false; | |
| return false; |
| if (asset.Name.StartsWith("ryujinx") && asset.Name.EndsWith(_platformExt) && asset.State == "uploaded") | ||
| { | ||
| _buildUrl = asset.BrowserDownloadUrl; | ||
| return true; |
There was a problem hiding this comment.
Suggested change
| return true; | |
| return true; |
| } | ||
|
|
||
| _running = false; | ||
| return false; |
There was a problem hiding this comment.
Suggested change
| return false; | |
| return false; |
| await ContentDialogHelper.CreateErrorDialog( | ||
| LocaleManager.Instance[LocaleKeys.DialogUpdaterFailedToGetVersionMessage]); | ||
| _running = false; | ||
| return false; |
There was a problem hiding this comment.
Suggested change
| return false; | |
| return false; |
| { | ||
| request.Headers.Range = range; | ||
| } | ||
| return await _httpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead); |
There was a problem hiding this comment.
Suggested change
| return await _httpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead); | |
| return await _httpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebClienttoHttpClientasyncandawaitinstead ofResultPlease test by updating the app when prompted to make sure there's no regression. I only tested on Windows, but you can test again to make sure.
Also please check if I do something wrong or miss something 🙏🙏.