New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable keyboard controller input while swkbd is open (foreground) #6646
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
2226dac
to
2edd862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, though there may be a more fundamental problem here. We probably want all input to be invisible to an application while an applet is in the foreground in general. I think this will only really be an issue when we start doing LLE applets, but it's still important to consider.
This PR fixes #5625 by disabling the keyboard controller input while the swkbd applet is open.
Warning
This does not prevent keyboard controller inputs while the inline keyboard is active.
Thank you @music-discussion for figuring out the bug and describing it in the comments! It saved me quite some time and allowed me to create this PR quickly.