New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix err in consumeOne #729

Open

sljeff wants to merge 1 commit into RichardKnop:master from sljeff:fix-comsumeOne-err

sljeff commented Dec 23, 2021 •

edited

If b.consumeOne returns an err, StartConsuming will also returns (and usually re-run due to b.GetRetry()). But:

The two goroutines inside StartConsuming don't stop, and continue to pull messages from redis
The data already in the deliveries will not be requeue

To fix it, I add a channel. Before returning, it needs to:

Close the two goroutines
Requeue messages


          fix err in consumeOne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment