Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix edge coloring bug in plot_coupling_map (backport #12369) #12379

Merged
merged 1 commit into from May 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

Summary

Fixes #12354 .

Details and comments

The conversion to an undirected graph changes the edge ordering, causing it not to match the color ordering. This change uses a dictionary to recover the correct ordering.


This is an automatic backport of pull request #12369 done by [Mergify](https://mergify.com).

* fix edge coloring bug in plot circuit layout

* add release note

(cherry picked from commit 24f1436)
@mergify mergify bot requested review from nonhermitian and a team as code owners May 9, 2024 19:05
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label May 9, 2024
@github-actions github-actions bot added this to the 1.1.0 milestone May 9, 2024
@mtreinish mtreinish enabled auto-merge May 9, 2024 19:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9022237932

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.632%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/gate_map.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 88.02%
qiskit/visualization/gate_map.py 1 6.98%
crates/qasm2/src/lex.rs 3 92.62%
crates/qasm2/src/parse.rs 6 97.15%
Totals Coverage Status
Change from base Build 9019014207: 0.02%
Covered Lines: 62250
Relevant Lines: 69451

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue May 10, 2024
Merged via the queue into stable/1.1 with commit a938606 May 10, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.1/pr-12369 branch May 10, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants