Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 1.1.0 release #12371

Merged
merged 37 commits into from May 16, 2024
Merged

Prepare 1.1.0 release #12371

merged 37 commits into from May 16, 2024

Conversation

sbrandhsn
Copy link
Contributor

@sbrandhsn sbrandhsn commented May 8, 2024 •
edited

Summary

This commit prepares the repo for the 1.1.0 release. It updates the version numbers to indicate it is the final 1.1.0 release, and updates the release notes to prepare them for publishing. Once this merges this commit should be used to tag the 1.1.0 release.

Details and comments

TODO:

  • Select topics for prelude draft
  • Finish prelude draft
  • Go through and copy-edit and update the release notes
  • Fix Sphinx Crossrefs

@mtreinish mtreinish added this to the 1.1.0 milestone May 9, 2024
@mtreinish mtreinish added the Changelog: None Do not include in changelog label May 9, 2024
@sbrandhsn sbrandhsn marked this pull request as ready for review May 13, 2024 16:25
@sbrandhsn sbrandhsn requested review from a team as code owners May 13, 2024 16:25
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

mtreinish
mtreinish reviewed May 14, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial comments from a quick skim through the release notes, I'll do a more thorough pass soon.

releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa50f5a.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/star-prerouting-0998b59880c20cef.yaml Show resolved Hide resolved
qiskit/primitives/__init__.py Show resolved Hide resolved
@sbrandhsn
Copy link
Contributor Author

Thanks for your comments so far, I think I addressed them in the most recent commit. :-)

mtreinish
mtreinish reviewed May 14, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the plots in the star pre-routing block. Without the second colon it's being treated as a comment by sphinx.

releasenotes/notes/1.1/star-prerouting-0998b59880c20cef.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/star-prerouting-0998b59880c20cef.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/star-prerouting-0998b59880c20cef.yaml Outdated Show resolved Hide resolved
mtreinish
mtreinish reviewed May 15, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a pass through all the notes (except the fix notes) that were in the PR diff to start. I still want to go through the rest of the notes quickly to see if anything else stands out to me.

releasenotes/notes/1.1/added-parameter-ctrl_state-mcx-816dcd80e459a5ed.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa50f5a.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa50f5a.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa50f5a.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/add-ctrl_state-mcp-parameter-b23562aa7047665a.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/optimize-annotated-conjugate-reduction-656438d3642f27dc.yaml Show resolved Hide resolved
releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml Outdated Show resolved Hide resolved
releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml Outdated
speedups while also decreasing the size of the transpiled quantum circuits in many cases. Specifically,
:class:`.ElidePermutations` and :class:`.StarPreRouting` have been demonstrated to have a significant
impact on the routing output quality and runtime, :class:`.RemoveFinalReset` can improve quantum circuits
that include resets and :class:`.OptimizeAnnotated` improves the processing of annotated operations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OptimizeAnnotated isn't new, but it has been improved in this release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that pass from the prelude. :-)

releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml Outdated Show resolved Hide resolved
@sbrandhsn
Copy link
Contributor Author

Thanks for the review so far, I included the requested changes. :-)

sbrandhsn and others added 11 commits May 16, 2024 11:36
sbrandhsn and others added 21 commits May 16, 2024 11:36
@sbrandhsn @mtreinish
prelude update
d2ce854
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml
eeb4e77 
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/added-parameter-ctrl_state-mcx-816dcd80…
fa2923b 
…e459a5ed.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa5…
e6c6af8 
…0f5a.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa5…
23c3d50 
…0f5a.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa5…
617e89d 
…0f5a.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/add-ctrl_state-mcp-parameter-b23562aa70…
0bcf66b 
…47665a.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml
f524374 
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml
98cda11 
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml
eb3803f 
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
comments from code review
4b7cad1
@sbrandhsn @mtreinish
Apply suggestions from code review
f1bc34e 
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/abstract-commutation-analysis-3518129e9…
fd5cf84 
…1a33599.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @ihincks @mtreinish
Update qiskit/primitives/containers/shape.py
e6a69df 
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
@sbrandhsn @mtreinish
Update shape.py
6adc048
@sbrandhsn @1ucian0 @mtreinish
Apply suggestions from code review
3ace3ba 
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
@sbrandhsn @mtreinish
Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml
e6a76a0 
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@sbrandhsn @1ucian0 @mtreinish
Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml
fa162dc 
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
@sbrandhsn @mtreinish
.
be33359
@sbrandhsn @mtreinish
.
fde8a63
@mtreinish
Move and update new fix release notes
2e749fb
@mtreinish
Copy link
Member

I had to do a manual rebase and force push to update the branch here because reno has a hard time tracking things across a merge commit in the PR. The only real change from the prior version is 2e749fb

@jakelishman jakelishman mentioned this pull request May 16, 2024
Merged
mtreinish and others added 3 commits May 16, 2024 12:47
@mtreinish
Small tweaks
e873ae9
@mtreinish
Remove fix note for private API
6ec3efe
@jakelishman @mtreinish
Add release notes for manual Var and Store (Qiskit#12421)
6199cc5 
* Add release notes for manual `Var` and `Store`

This adds the release notes and updates some small portions of
documentation that were previously missed surrounding the new manual
`Var` storage locations.

This includes documenting all new keyword arguments to methods, upgrade
instructions for providers, and adding the `Var.new` method to the
documentation, which was previously erroneously omitted.

* Fix Sphinx typo

* Fix another Sphinx typo

* Move QPY version bump to upgrade

* Unify base release note

* Reword providers upgrade note

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit 554e661)
@mtreinish mtreinish requested a review from jyu00 as a code owner May 16, 2024 18:13
mtreinish
mtreinish approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, there might be some other small things in the release notes but we can fix this after the fact fairly easily. Thanks for the hard work taking care of this and shepherding this release @sbrandhsn!

@mtreinish mtreinish merged commit 7d29dc1 into Qiskit:stable/1.1 May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucian0 1ucian0 1ucian0 left review comments

@ihincks ihincks ihincks left review comments

@ShellyGarion ShellyGarion ShellyGarion left review comments

@mtreinish mtreinish mtreinish approved these changes

@jyu00 jyu00 Awaiting requested review from jyu00 jyu00 is a code owner

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sbrandhsn @qiskit-bot @mtreinish @1ucian0 @ihincks @ShellyGarion @jakelishman