New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add HLS plugin benchmarks #12329
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 8982169336Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
hls_config = HLSConfig(clifford=["ag"]) | ||
pm = PassManager([HighLevelSynthesis(hls_config=hls_config)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably move this to setUp()
to avoid this skewing the measurements. The entire contents of this function is what ends up being measured.
hls_config = HLSConfig(clifford=["ag"]) | ||
pm = PassManager([HighLevelSynthesis(hls_config=hls_config)]) | ||
|
||
for _ in range(self.num_samples): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to do this explicitly the asv harness handles taking multiple samples to get the statistical sampling. We probably want to move the random clifford construction to setup too though to avoid randomization impacting the measurements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we nonetheless consider multiple different random linear functions, random cliffords, etc. to avoid overtuning synthesis algorithms on specific circuits?
Thanks for the suggestions. I have moved the circuit and pm construction to the setup and fixed the random seeds, and applied a few offline suggestions from @alexanderivrii. So far the benchmarks run but I wonder if the circuit I am currently building makes sense for the
|
Summary
This is a first attempt at adding a file to test potential performance improvements in HLS plugins.
Details and comments