Removing consider-using-enumerate from lint exclusions and updates #12286
Conversation
qiskit-bot
added
the
Community PR
Pull Request Test Coverage Report for Build 9080728698Details
💛 - Coveralls |
joesho112358
requested review from
nonhermitian,
a team,
alexanderivrii and
ShellyGarion
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
# Conflicts: # pyproject.toml
|
@mtreinish as a heads up, the latest commit probably needs your eyes. specifically in the |
qiskit/transpiler/passmanager.py
Outdated
| original_qubits_reverse = {v: k for k, v in original_qubit_indices.items()} | ||
| original_qubits = [] | ||
| for i in range(len(original_qubits_reverse)): | ||
| original_qubits.append(original_qubits_reverse[i]) | ||
| for v, k in original_qubits_reverse.items(): | ||
| original_qubits.append(k) |
There was a problem hiding this comment.
This looks like a behavioural change to me. Dictionary iteration order is insertion order, but the previous form was specifically looking up in numerical order of the v items.
The vs are ints here (from 0 to n-1) and the k are Qubit instances.
There was a problem hiding this comment.
ah, i see it now. ok, i'll have to update this
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Summary
#9614 - removing consider-using-enumerate
Details and comments
Updates for removing this rule if wanted. Open to suggestions on variable names