Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SamplerPub and EstimatorPub public #12222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make SamplerPub and EstimatorPub public #12222

wants to merge 1 commit into from
+19 −5

Conversation

ihincks
Copy link
Contributor

@ihincks ihincks commented Apr 19, 2024

Summary

This PR is a reversion of #11678.

Details and comments

This PR is blocked by #11594.

@ihincks ihincks added the mod: primitives Related to the Primitives module label Apr 19, 2024
@ihincks ihincks added this to the 1.1.0 milestone Apr 19, 2024
@ihincks ihincks requested review from a team as code owners April 19, 2024 04:12
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ajavadia
  • @levbishop
  • @t-imamichi

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8748283714

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 89.263%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 93.38%
crates/qasm2/src/parse.rs 6 96.69%
Totals Coverage Status
Change from base Build 8748077179: -0.002%
Covered Lines: 60312
Relevant Lines: 67567
💛 - Coveralls

t-imamichi
t-imamichi approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-imamichi t-imamichi added the Changelog: None Do not include in changelog label Apr 19, 2024
@1ucian0 1ucian0 added Changelog: API Change Include in the "Changed" section of the changelog and removed Changelog: None Do not include in changelog labels Apr 19, 2024
@mtreinish mtreinish added Changelog: New Feature Include in the "Added" section of the changelog and removed Changelog: API Change Include in the "Changed" section of the changelog labels Apr 29, 2024
@jakelishman jakelishman modified the milestones: 1.1.0, 1.2.0 May 1, 2024
@jakelishman
Copy link
Member

Bumping to 1.2 as I understand that to be the state from discussion with Ian.

@t-imamichi t-imamichi mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-imamichi t-imamichi t-imamichi approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: primitives Related to the Primitives module
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ihincks @qiskit-bot @coveralls @jakelishman @t-imamichi @1ucian0 @mtreinish