Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BackendSamplerV2 when used with an empty classical register #12055

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

garrison
Copy link
Member

@garrison garrison commented Mar 20, 2024

Summary

Fixes #12043

Details and comments

Remaining action items:

@coveralls
Copy link

coveralls commented Mar 20, 2024

Pull Request Test Coverage Report for Build 8383041257

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.005%) to 89.328%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 93.13%
crates/qasm2/src/parse.rs 6 97.15%
Totals Coverage Status
Change from base Build 8376619819: 0.005%
Covered Lines: 59795
Relevant Lines: 66939

💛 - Coveralls

@garrison garrison marked this pull request as ready for review March 21, 2024 19:56
@garrison garrison requested review from a team as code owners March 21, 2024 19:56
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @t-imamichi

Copy link
Contributor

@ihincks ihincks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing! LGTM.

@ihincks ihincks added the mod: primitives Related to the Primitives module label Mar 21, 2024
Copy link
Member

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding and fixing this issue. LGTM

@t-imamichi t-imamichi added the Changelog: None Do not include in changelog label Mar 22, 2024
@t-imamichi t-imamichi added this pull request to the merge queue Mar 22, 2024
Merged via the queue into Qiskit:main with commit b0d2062 Mar 22, 2024
12 checks passed
garrison added a commit to garrison/qiskit-ibm-runtime that referenced this pull request Mar 25, 2024
This is a port of Qiskit/qiskit#12055
to this repository, since this repository has its own fork of
`BackendSamplerV2` until Qiskit 1.1 is released (Qiskit#1523).
kt474 pushed a commit to Qiskit/qiskit-ibm-runtime that referenced this pull request Mar 25, 2024
)

This is a port of Qiskit/qiskit#12055
to this repository, since this repository has its own fork of
`BackendSamplerV2` until Qiskit 1.1 is released (#1523).
kt474 pushed a commit to Qiskit/qiskit-ibm-runtime that referenced this pull request Mar 25, 2024
)

This is a port of Qiskit/qiskit#12055
to this repository, since this repository has its own fork of
`BackendSamplerV2` until Qiskit 1.1 is released (#1523).
@garrison garrison deleted the backendsamplerv2-empty-creg branch April 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog mod: primitives Related to the Primitives module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BackendSamplerV2 fails to run with empty classical register
5 participants