Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubi gateway #1338

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Ubi gateway #1338

wants to merge 6 commits into from

Conversation

akihikokuroda
Copy link
Collaborator

@akihikokuroda akihikokuroda commented May 17, 2024

Summary

Change the base image of the gateway pod to the UBI base image.

Details and comments

I couldn't find the python 3.10 UBI base image. There are only 3.9 and 3.11 UBI images. This PR used the python 3.11 UBI image. The Ray version is also changed to 2.22.0 for python 3.11 support.

There are issues in the decorator example with the 3.10 client. The client has to be 3.11 to use the decorator.

@akihikokuroda akihikokuroda marked this pull request as draft May 17, 2024 15:12
@akihikokuroda
Copy link
Collaborator Author

This PR is getting

Traceback (most recent call last):\n  File "/tmp/ray/session_2024-05-24_09-51-11_367618_9/runtime_resources/working_dir_files/_ray_pkg_73b93c0edc2627f6/entrypoint_e9bb5f20.py", line 10, in <module>\n    function = cloudpickle.load(file)\n               ^^^^^^^^^^^^^^^^^^^^^^\nTypeError: code() argument 13 must be str, not int\n'

in the running_programs_using_decorators sample.

@akihikokuroda akihikokuroda marked this pull request as ready for review May 28, 2024 17:49
Copy link
Collaborator

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though since this requires bumping the Ray version I think we should hold off on merging it until after the next release as per #1272 (comment)

@psschwei psschwei added the on-hold On hold due to any reason label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold On hold due to any reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants