Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Provider as parent class from QiskitRuntimeService #1689

Merged
merged 15 commits into from
May 30, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented May 17, 2024

Summary

  • Removed Qiskit Provider parent class from QiskitRuntimeService and FakeProviderForBackendV2
  • Deprecated get_backend()
  • Deprecated V1 fake backends
  • Deprecated FakeProvider

Details and comments

Fixes #1589
Fixes #1261
Fixes #1604
Fixes #1505

@kt474 kt474 added the Changelog: Deprecation Include in Deprecated section of changelog label May 17, 2024
@kt474 kt474 marked this pull request as ready for review May 17, 2024 18:56
@coveralls
Copy link

coveralls commented May 20, 2024

Pull Request Test Coverage Report for Build 9307679837

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 17 (82.35%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 82.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/qiskit_runtime_service.py 4 5 80.0%
qiskit_ibm_runtime/fake_provider/fake_provider.py 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/qiskit_runtime_service.py 1 78.72%
qiskit_ibm_runtime/fake_provider/fake_provider.py 2 62.9%
Totals Coverage Status
Change from base Build 9307538725: 0.05%
Covered Lines: 6001
Relevant Lines: 7294

💛 - Coveralls

@kt474 kt474 requested a review from ptristan3 May 22, 2024 16:56
@kt474 kt474 merged commit 9104f55 into Qiskit:main May 30, 2024
20 checks passed
@kt474 kt474 deleted the remove-provider-parent branch May 30, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in Deprecated section of changelog
Projects
None yet
3 participants