Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding Incorrect padding error #1682

Merged
merged 4 commits into from
May 20, 2024
Merged

Conversation

kt474
Copy link
Member

@kt474 kt474 commented May 15, 2024

Summary

Need to wait for server side changes to fully test. I'm still a bit confused about this bug -

if isinstance(obj, np.ndarray):
    if obj.dtype == object: # obj.dtype for the ndarray causing the bug is float64
        ...
    elif obj.ndim: # this value is 1? Do we need to check for obj.size instead
        ...

Update: there was an issue with metadata serialization on the server side which is also being patched. Also updating the decoder on the client side here

Details and comments

Fixes #

@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label May 15, 2024
@kt474 kt474 marked this pull request as draft May 15, 2024 19:02
@coveralls
Copy link

coveralls commented May 16, 2024

Pull Request Test Coverage Report for Build 9163053346

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 82.74%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/utils/json.py 3 4 75.0%
Totals Coverage Status
Change from base Build 9162910154: -0.007%
Covered Lines: 6232
Relevant Lines: 7532

💛 - Coveralls

@kt474 kt474 changed the title Fix 0-d zne options encoding bug Fix encoding Incorrect padding error May 20, 2024
@kt474 kt474 marked this pull request as ready for review May 20, 2024 18:00
@kt474 kt474 merged commit 6ef071b into Qiskit:main May 20, 2024
20 checks passed
@kt474 kt474 deleted the zero-d-encoding-bug branch May 20, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants