Fixes failing task tests for new engine #13456
Conversation
desertaxle
changed the title
src/prefect/new_task_engine.py
Outdated
| # We sometimes call this prior to setting up the run context, so we create a temporary | ||
| # context here | ||
| # TODO: Should we set up the run context earlier in Engine.start? | ||
| log_prints = should_log_prints(self.task) | ||
| task_run_context = TaskRunContext( | ||
| task=self.task, | ||
| log_prints=log_prints, | ||
| task_run=self.task_run, | ||
| parameters=self.parameters, |
There was a problem hiding this comment.
This is a hack to get the tests to pass. Should we move the setup of the task run context before calling Engine.begin_run?
There was a problem hiding this comment.
Yep this definitely feels out of place to me too. I think you're right about moving it earlier so we don't have to do this here
There was a problem hiding this comment.
I added a context setup before beginning the run in 2311030, which worked. We still need to set up the context on each execution to ensure we have the latest task run meta data, but I don't think there's any harm in that.
desertaxle
force-pushed
the
fix-task-tests
branch
from
999259b
to
a18ef14
Compare
src/prefect/new_task_engine.py
Outdated
| # We sometimes call this prior to setting up the run context, so we create a temporary | ||
| # context here | ||
| # TODO: Should we set up the run context earlier in Engine.start? | ||
| log_prints = should_log_prints(self.task) | ||
| task_run_context = TaskRunContext( | ||
| task=self.task, | ||
| log_prints=log_prints, | ||
| task_run=self.task_run, | ||
| parameters=self.parameters, |
There was a problem hiding this comment.
Yep this definitely feels out of place to me too. I think you're right about moving it earlier so we don't have to do this here
This PR fixes the remaining failing tests for tasks with the new engine. 5 tests still fail because they involve calling async tasks in sync flows or the
SequentialTaskRunner. Makes a couple of fixes in caching and adds support for input resolution andwait_forfor flows in the new engine.Example
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
netlify.tomlfor files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.ymlnavigation.