Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pylint to requirements-dev.txt #5697

Merged
merged 6 commits into from
May 20, 2024
Merged

Conversation

Shiro-Raven
Copy link
Collaborator

@Shiro-Raven Shiro-Raven commented May 16, 2024

Context:
Pylint was missing from the requirements-dev.txt despite being needed for the CI pipeline and pre-commit.

Description of the Change:
Added pylint==2.7.4, mirroring the version used in the CI pipeline.

[sc-63430]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (3543271) to head (e948fe5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5697      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         415      415              
  Lines       38886    38594     -292     
==========================================
- Hits        38762    38469     -293     
- Misses        124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

requirements-dev.txt Outdated Show resolved Hide resolved
Shiro-Raven and others added 2 commits May 17, 2024 09:57
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
@Shiro-Raven Shiro-Raven merged commit 5d9daa3 into master May 20, 2024
38 checks passed
@Shiro-Raven Shiro-Raven deleted the ad/add-pylint-to-dev-reqs branch May 20, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants