enable best practices validation #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API est féminin, tandis que pipeline est masulin. Je me suis permis de mettre des majuscules aux noms d'objets de l'API qui sont en anglais. A valider
Quelques typos et tournures de phrase corrigées
…st in English, because the French version is used everywhere later on.
Code samples: add CMakeLists.txt
It looks like the repo https://github.com/RayTracing/InOneWeekend now points to https://github.com/RayTracing/raytracing.github.io . Updated the link to reflect this.
Update link to Ray Tracing book
data -> date
Update 04_Swap_chain_recreation.md
Mention std::clamp in explanatory comment instead of min/max
Fix minor typo in french translation
Add full name for vkBindXMemory functions in french translation
Chnage createFrameBuffers to createFramebuffers because it's written as "createFramebuffers" in the source code
Change createFrameBuffers to createFramebuffers
Fixed getMaxUsableSampleCount() formatting
- Removed no-longer updated quick reference - Update link to chunked Vulkan 1.2 spec - Added link to the Khronos Vulkan Guide
Added Arch Linux support, plus a "`make`" formatting fix.
Add Arch Linux support
Use Vulkan 1.3 spec
* Update tutorial for command buffer re-recording Means the code now calls recordCommandBuffer every frame instead of ahead of time Many changes to the structure of chapters 14 & 15, with small changes to subsequent chapters. Primary focus was shifting everything away from 'swapchain image count' to MAX_FRAMES_IN_FLIGHT. This has caused a lot of chapter 15 to need to be rewritten. Such as: Introducing fences alongside semaphores and not later; Waiting on a fence at the start of the frame before introducing acquireNextImage; consolidating the Frames In Flight concepts to apply to command buffers, fences, and semaphores at the same time. Chapter 14 saw command buffer allocation reduced to 1 at a time. This allows the concept of Frames in Flight to not need introduction before having a triangle drawing on the screen. * Update introduction to semaphores and fences Greatly improve the descriptions of semaphores and fences before their introduction into the code. Provide examples with psuedo code. By using max_frames_in_flight command buffers & semaphores, we dont need to keep track of previously sumitted frames' fences and wait on them "just in case". This removes a lot of the confusion I had when I first was trying to understand the vulkan update loop. * Remove accidental code changes Un-comment vkDeviceWaitIdle and remove resizing of imagesInFlight (which was removed) * Use uint32_t instead of size_t for currentFrame * Address typos and fixup changes for re-recording command buffers PR * Add description of fences needing explicit resetting while semaphores are automatic * Elaborate on why 2 frames in flight are chosen * Fix deadlock in resizing from resetting the fence too early Because acquiring the swapchain image index may cause drawFrame to return early, it was possible to cause the next vkWaitForFences to deadlock. By delaying fence resetting till after acquiring, it prevents the deadlock.
Overv
force-pushed
the
main
branch
2 times, most recently
from
f2764d9
to
ddd8649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some best practices validation warnings.