Add scripting support for cost expenditures (requires #21932) #22039
+140
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
This PR adds on scripting functionality to #21932.
A few comments:
ExpenditureTypeEnum
enum in the.d.ts
instead of a number for the functions. It's duplicative with the text of the existingExpenditureType
, but serves a different purpose. If it decided that this makes the .d.ts file too bloated, another option is to add these number as comments into the ExpenditureType so developers have something to reference.I'd appreciate any testing to ensure this works as expected. You can download the built version of this on many systems via the built tests (though some failed and I'm not sure why), and I've attached a plugin you can use to test the main functionality.