Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #13047: De-duplicate track type normalisation in TrackRemoveAction #21553

Merged
merged 1 commit into from
May 29, 2024
Merged

Close #13047: De-duplicate track type normalisation in TrackRemoveAction #21553

merged 1 commit into from
May 29, 2024

Conversation

shakthi124
Copy link
Contributor

Refactored TrackRemoveAction class to remove duplicate code:

switch (_trackType)
{
    case TRACK_ELEM_BEGIN_STATION:
    case TRACK_ELEM_MIDDLE_STATION:
        comparableTrackType = TRACK_ELEM_END_STATION;
}

@shakthi124 shakthi124 mentioned this pull request Mar 9, 2024
Closed
@Gymnasiast Gymnasiast linked an issue Mar 9, 2024 that may be closed by this pull request
Track type normalising duplication in Game Actions #13047
Closed
@Gymnasiast Gymnasiast self-requested a review March 9, 2024 10:24
ZehMatt
ZehMatt previously requested changes Mar 10, 2024
View reviewed changes
src/openrct2/actions/TrackRemoveAction.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the stale-pr label. If you're awaiting feedback from a developer, please send us a reminder (either here or on Discord).

@github-actions GitHub Actions
Copy link

This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the stale-pr label. If you're awaiting feedback from a developer, please send us a reminder (either here or on Discord).

@Gymnasiast Gymnasiast force-pushed the swije13047 branch 2 times, most recently from a43a2ce to 43429a3 Compare May 29, 2024 20:30
@shakthi124 @Gymnasiast
Close OpenRCT2#13047: De-duplicate track type normalisation in TrackR…
8673ebe 
…emoveAction

Co-authored-by: Gymnasiast <gymnasiast90@users.noreply.github.com>
@Gymnasiast Gymnasiast changed the title Close:13047 Track type normalising duplication in Game Actions Close #13047: De-duplicate track type normalisation in TrackRemoveAction May 29, 2024
@Gymnasiast Gymnasiast dismissed ZehMatt’s stale review May 29, 2024 20:39

Request has been applied

@Gymnasiast Gymnasiast enabled auto-merge (squash) May 29, 2024 20:42
@Gymnasiast Gymnasiast added this to the v0.4.12 milestone May 29, 2024
@Gymnasiast Gymnasiast merged commit 7fb3022 into OpenRCT2:develop May 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gymnasiast Gymnasiast Gymnasiast approved these changes

@ZehMatt ZehMatt ZehMatt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.

Track type normalising duplication in Game Actions
3 participants
@shakthi124 @Gymnasiast @ZehMatt