Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French support for several games #21333

Open
wants to merge 3 commits into
base: bleed
Choose a base branch
from
Open

Conversation

dangherve
Copy link

-cnc
-ra
-ts

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋

What would be the best way to test this PR? I don't know if the french versions are available to download as freeware

I'm afraid that at this moment we might not be able accept this PR. Our WIP localisation system #10475 does not support asset switching, and I can only assume the massive amount of bugs and missing features we'll run into when we attempt to implement it.

Meaning at this moment this PR might just add a bunch of maintenance overheads without much gain, stressing our already lacking in manpower contributors even thinner. However once we do get asset localisation this PR will be instrumental

@dangherve
Copy link
Author

Hi

Not sure if we can have original image as freeware found on "abandon-ware" not sure that it should be the same legal issue

Do not think this will add maintenance overhead it just use french sound/video using the french cd.

But if this problematic not need to merge we can leave it open or merge in a different branch

@Mailaender Mailaender changed the title Add Frennch support for several games Add French support for several games Feb 8, 2024
@abcdefg30 abcdefg30 mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants