Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add XKoreProxy (Xkore 3) support for vRO #3529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

royalgarter
Copy link
Contributor

No description provided.

This was referenced Oct 20, 2021
@ya4ept
Copy link
Contributor

ya4ept commented Oct 23, 2021

I think that we should move the code for receiving the token into a separate plugin. Let's try using the vRO_auth.pl plugin?

@ya4ept ya4ept added this to In progress in vRO via automation Oct 23, 2021
@ya4ept ya4ept added new feature server: vRO https://ro.vtcgame.vn/ labels Oct 23, 2021
@royalgarter
Copy link
Contributor Author

I think that we should move the code for receiving the token into a separate plugin. Let's try using the vRO_auth.pl plugin?

Yes, please go ahead

@@ -715,4 +757,124 @@ sub getRecvPackets {
return \%rpackets;
}

sub DecryptMessageID {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return $MID;
}

sub sendMasterLogin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do $messageSender->sendMasterLogin instead of redefining this function.

$messageSender->sendToServer($data);
debug "Sent sendMasterLogin\n", "sendPacket", 2;
}
sub pinEncode {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do $messageSender->sendLoginPinCode instead of redefining this function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you created a new commit with your edit please. I'm a little bit busy these days.

@ya4ept ya4ept moved this from In progress to To do in vRO Nov 17, 2021
@OpenKore OpenKore deleted a comment from blackcat000 Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature server: vRO https://ro.vtcgame.vn/
Projects
vRO
  
TODO
Development

Successfully merging this pull request may close these issues.

None yet

3 participants