Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor monologue and SWE agent to use the messages in state history #1863

Merged
merged 17 commits into from
May 23, 2024

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented May 17, 2024

This PR updates monologue agent to the current architecture. It's a follow-up to #1847.
Necessary for the #1771 to start working with the right components.

@rbren I assume we need to take a look at any agent who currently has some sort of own history or copies, for the session management. Done.

  • updated monologue
  • updated swe agent
  • planner and micro are well-behaved already

Please note that this PR is cutting off monologue from memory condenser, since it doesn't maintain its own history of events anymore, thus can't directly replace it. This can be reworked and re-connected after 1810 and 1771.

@enyst enyst marked this pull request as draft May 17, 2024 16:10
@enyst enyst marked this pull request as ready for review May 18, 2024 12:45
@enyst enyst changed the title Refactor monologue to use the messages in state history Refactor monologue and SWE agent to use the messages in state history May 18, 2024
@enyst enyst requested a review from rbren May 18, 2024 19:01
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but I had one naming suggestion.

agenthub/monologue_agent/agent.py Outdated Show resolved Hide resolved
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@neubig
Copy link
Contributor

neubig commented May 22, 2024

I approve, but I'd kinda like to wait till @rbren merges the massive commit here just to prevent conflicts from blocking his work: #1810

Hopefully that will happen in a few hours, and then we can merge this in after that.

@enyst
Copy link
Collaborator Author

enyst commented May 22, 2024

Definitely. Not blocking, but it's quite likely there'll be some conflicts. I'll take care of that.

@enyst enyst marked this pull request as draft May 22, 2024 21:45
@enyst enyst marked this pull request as ready for review May 22, 2024 22:58
@enyst enyst enabled auto-merge (squash) May 23, 2024 07:08
@enyst enyst merged commit 0eccf31 into OpenDevin:main May 23, 2024
19 of 20 checks passed
super-dainiu pushed a commit to super-dainiu/OpenDevin that referenced this pull request May 23, 2024
…OpenDevin#1863)

* Refactor monologue to use the messages in state history

* add messages, clean up

* fix monologue

* update integration tests

* move private method

* update SWE agent to use the history from State

* integration tests for SWE agent

* rename monologue to initial_thoughts, since that is what it is
@enyst enyst mentioned this pull request May 23, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants