Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Fix missing underscores for PascalCase enum values #4837 #18594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renatomameli
Copy link

@renatomameli renatomameli commented May 7, 2024

Resolves: #4837

Addresses an issue with the conversion of enum values to valid variable names. When the enum value is a string and contains multiple words without separators (e.g., TestCase), underscores between the words were previously missing (e.g., "TESTCASE").

To address this issue, the existing underscore method is now applied to the value before all characters are converted to uppercase letters. The underscore method converts CamelCase to SCREAMING_SNAKE_CASE while preserving the case of individual words (e.g., TestCase becomes TEST_CASE)

Corresponding tests have been added.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@renatomameli
Copy link
Author

@lwlee2608 @martin-mfg

@renatomameli
Copy link
Author

@wing328 samples updated

@renatomameli renatomameli force-pushed the renatomameli-fix-enum-PascalCase-underscores branch 2 times, most recently from 41e4593 to 3a6a427 Compare May 17, 2024 07:41
@renatomameli renatomameli force-pushed the renatomameli-fix-enum-PascalCase-underscores branch from 3a6a427 to edb4b0f Compare May 17, 2024 08:00
@wing328 wing328 modified the milestones: 7.6.0, 7.7.0 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][Java] Enum name should have underscore in case the value is pascal case
2 participants