Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(php-nextgen): allow to serialize collections of enums #18549

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SomeBdyElse
Copy link

@SomeBdyElse SomeBdyElse commented May 1, 2024

When serializing collections, make sure to serialize the members of the collection first, before applying http_build_query or implode.

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

When serializing collections, make sure to serialize the members of the collection first, before applying http_build_query or implode.
@wing328
Copy link
Member

wing328 commented May 1, 2024

@SomeBdyElse thanks for the PR. what about adding a test or 2 in https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/php-nextgen/OpenAPIClient-php/test/ObjectSerializerTest.php ?

please follow step 3 to update the samples as well.

@SomeBdyElse
Copy link
Author

Hi @wing328 !

Thank you for looking at the PR. Unfortunately I do not have a Java development environment to build the project and examples. I might try https://github.com/OpenAPITools/openapi-generator?tab=readme-ov-file#development-in-docker .

Is https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/php-nextgen/OpenAPIClient-php/test/ObjectSerializerTest.php the right file to create the tests? I thought that the entire samples/client/petstore/php-nextgen/ path is a generated example.

@wing328
Copy link
Member

wing328 commented May 2, 2024

the right file to create the tests? I thought that the entire samples/client/petstore/php-nextgen/ path is a generated example.

these folder contains integration tests too so do not purge the whole folder when regenerating samples

@wing328
Copy link
Member

wing328 commented May 8, 2024

Thank you for looking at the PR. Unfortunately I do not have a Java development environment to build the project and examples. I might try https://github.com/OpenAPITools/openapi-generator?tab=readme-ov-file#development-in-docker .

yes, please try that and let me know if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants