fix(http): use proxy agent setup that supports proxy env variables with no_proxy
#781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #762, where the "no-proxy" environment configuration was ignored.
With this PR I moved from the usage of
https-proxy-agent
toproxy-agent
. This was done ashttps-proxy-agent
was configured to take the proxy url from the environment but the library itself doesn't handleNO_PROXY
/no_proxy
configuration.proxy-agent
on the other side, is sitting on top of thehttps-proxy-agent
andhttp-proxy-agent
library and decides if the proxy is used based on the request URL and the domains specified in the "no proxy" environment variables.To test this
HTTP_PROXY
,HTTPS_PROXY
,http_proxy
,https_proxy
,NO_PROXY
,no_proxy
.generator-cli.repository.downloadUrl
configno_proxy
andNO_PROXY
environment variables OR if you don't have a mirror at hand, just add the default domain specified in config.schema.json and ensure that you have a way to verify that the traffic went not through the proxy.