Housing PlotIndex support - addresses #218 in the develop branch #296
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirmmin
approved these changes
Sep 27, 2020
There was a problem hiding this comment.
Looks good to me.
@Rawaho, I would say we need to look into this worldPosition thing. I noticed this when working on decor entities. The Z and X and flipped locally, so calculating world positions from a local decor position requires you to take the localZ and use that in the worldX calculation. It's kinda crazy. It might help to have some sort of converter function rather than hacking code to flip things around (like the IsValidPlotForPosition method does, currently).
the vendor. Also corrects the IsValidPlotForPosition location calculation (Plot coordinates X,Z do not map to World coordinates X,Z), and the final return value. Known issues: 1) Currently requires the plotIndex database default to be set to 0 in order to properly set the plotIndex when placing on PlotIndex=0 from the vendor. 2) When placing in PlotIndex=0, the Y value in the database is not what you see in game. The position as placed in game does persist as expected across server loads so long as the plotIndex in the database is properly set to 0 (see 1). If the plotIndex is set to Int.MaxValue instead of 0, the item will raise from its indended location after a server restart. Fixed comment typo. Update IDecor interface.
Rawaho
force-pushed
the
Housing-PlotIndex
branch
from
ff4c263
to
4a8c034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the commit message, the known issues are:
to 0 in order to properly set the plotIndex when placing on PlotIndex=0
from the vendor.
see in game. The position as placed in game does persist as expected across
server loads so long as the plotIndex in the database is properly set to 0
(see 1). If the plotIndex is set to Int.MaxValue instead of 0, the item will
raise from its intended location after a server restart.