Replies: 1 comment
-
You can just open an issue for it, no need to do a pull-request unless you really want to. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I discovered a bug which is fixed by adding one line of code. Do I have to become a developer to get this done or do I need to open an issue? What is the best way to proceed? (By the way, I do not have objections in developing. For me, it is a question of time setting up the environment, and getting everything started.)
The bug in question:
ghidra.util.bytesearch.SequenceSearchState
public void apply(InputStream in, long maxBytes, ArrayList<Match> match, TaskMonitor monitor)
* @param monitor - if non-null, check for user cancel, and maintain progress info
long progress = monitor.getProgress();
Problem:
If one passes "null" for the TaskMonitor object, line 268 throws an exception, which is in contrast to the stated behavior in the docstring in line 263. In the same function in line 341, however, there is a test
monitor != null
.Solution:
Around line 268, there should be a test for a null-object, as in line 341.
Thank you in advance for guidance
Lutz
Beta Was this translation helpful? Give feedback.
All reactions