Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add cc.sizeof #1694

Merged
merged 2 commits into from
May 21, 2024
Merged

[Core] Add cc.sizeof #1694

merged 2 commits into from
May 21, 2024

Conversation

schweitzpgi
Copy link
Collaborator

And a distinct operation for determining the memory size in bytes of a type.

  • Change GKE to use new sizeof op.
  • Add to codegen.
  • Add roundtrip.
  • Fix tests.

Description

And a distinct operation for determining the memory size in bytes of a
type.

- Change GKE to use new sizeof op.
- Add to codegen.
- Add roundtrip.
- Fix tests.
github-actions bot pushed a commit that referenced this pull request May 17, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 20, 2024
@schweitzpgi schweitzpgi enabled auto-merge (squash) May 20, 2024 20:21
@schweitzpgi schweitzpgi requested a review from 1tnguyen May 20, 2024 21:17
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just once question about potential error messages.

lib/Optimizer/Dialect/CC/CCOps.cpp Show resolved Hide resolved
@schweitzpgi schweitzpgi merged commit 0c18a55 into NVIDIA:main May 21, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants