A few perf. improvements for state handling #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure that we don't actually allocate state in tracer mode (e.g., library mode to detect mid-circuit measurements). - Skip state vector validation by default. - Add some more timing traces to custatevec backend for future analysis.
Didn't handle both the tracer path: execution manager and nvqir.
schweitzpgi
reviewed
May 3, 2024
schweitzpgi
reviewed
May 3, 2024
…ove unnecessary braces
schweitzpgi
reviewed
May 10, 2024
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
1tnguyen
merged commit 1cc7ce6
into
NVIDIA:experimental/stateHandling
112 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that we don't actually allocate state in tracer mode (e.g., in library mode to detect mid-circuit measurements).
Skip state vector validation by default.
Add some more timing traces to custatevec backend for future analysis.