Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] [Python] Follow-up for 'pycudaq-mlir' tests #1532

Closed
wants to merge 5 commits into from
Closed

[Tests] [Python] Follow-up for 'pycudaq-mlir' tests #1532

wants to merge 5 commits into from

Conversation

khalatepradnya
Copy link
Collaborator

Run the Python MLIR tests enabled in PR#1405 while building from source in the 'assets' dockerfile.

@khalatepradnya khalatepradnya self-assigned this Apr 17, 2024
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
8355120
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
d5ca105
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya khalatepradnya marked this pull request as draft April 18, 2024 00:26
@khalatepradnya
Copy link
Collaborator Author

Converting to draft till the CI stage for building assets is fixed...

bettinaheim
bettinaheim reviewed Apr 18, 2024
View reviewed changes
docker/build/assets.Dockerfile Outdated
--param nvqpp_site_config=build/targettests/lit.site.cfg.py
--param nvqpp_site_config=build/targettests/lit.site.cfg.py && \
"$LLVM_INSTALL_PREFIX/bin/llvm-lit" -v build/python/tests/mlir \
--param nvqpp_site_config=build/python/tests/mlir/lit.site.cfg.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python is built separately in its own stage. You will need to copy over the build folder from that stage. Scikit is used to build the python support; the pyproject.toml defines the build and disables building tests. I haven't checked where they would end up in if they are enabled during the build. Give it a go and let me know if you run into trouble.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 22, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
3a5ee9c
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
69b2133
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
c69bb5b
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
dce3c5e
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
da69993
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
07c6bd2
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
b5b2735
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
41f22e7
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 3, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
03401c5
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 3, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
27e3ce9
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 6, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
923976c
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 6, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
5afaeba
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 8, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
f057ca1
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 9, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
6db798d
github-actions bot pushed a commit that referenced this pull request May 10, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
7d43654
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

khalatepradnya and others added 5 commits May 10, 2024 08:14
@khalatepradnya
* Run the Python MLIR tests enabled in PR#1405 while building from
454eefb 
  source in the 'assets' dockerfile.

* Trying to always build 'python/tests/mlir'
@khalatepradnya
* Install 'pytest' module before running tests
5f5e248 
(should be installed beforehand)
@khalatepradnya
Update assets.Dockerfile
ad84745 
Change the order of running `pycudaq-mlir` tests
@khalatepradnya
* Addressing offline review comments
e87637e 
 -- Build wheel with tests enabled
 -- Run all tests in single stage
@khalatepradnya
* Attempt to build Python wheel with CUDAQ tools and CPP frontend
6f7bf3a 
  (dependencies for enabling tests).
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 10, 2024
@cuda-quantum-bot
Docs preview for PR #1532.
2585ff0
@khalatepradnya
Copy link
Collaborator Author

Closing this since it needs further work in build configuration.

Setting this flag in the toml file - CUDAQ_BUILD_TESTS=TRUE, results in failure to build wheel file since there are dependencies on 'C++ frontend' and 'tools' components. Merely setting both these flags CUDAQ_DISABLE_CPP_FRONTEND=FALSE and CUDAQ_DISABLE_TOOLS=FALSE still results in build failure. The building of Python-specific ctest tests (i.e. pycudaq-mlir) isn't isolated and needs further work.

@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
@bettinaheim
Copy link
Collaborator

@khalatepradnya I fixed the issues with building the tests for the wheels in #1603. There is an update needed in the pyproject.toml file to add numpy and pytest as requirements for the build-system, and I updated the CMakefile.txt to only add the top-level test subdirectory if the CUDAQ_DISABLE_CPP_FRONTEND is false. Please double check if that picks up all necessary tests, or if I missed some (I see 50 tests running).

@khalatepradnya
Copy link
Collaborator Author

@khalatepradnya I fixed the issues with building the tests for the wheels in #1603. There is an update needed in the pyproject.toml file to add numpy and pytest as requirements for the build-system, and I updated the CMakefile.txt to only add the top-level test subdirectory if the CUDAQ_DISABLE_CPP_FRONTEND is false. Please double check if that picks up all necessary tests, or if I missed some (I see 50 tests running).

Thank you, I will check.

@khalatepradnya khalatepradnya deleted the follow-up-1405 branch May 30, 2024 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bettinaheim bettinaheim bettinaheim left review comments

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

Assignees

@khalatepradnya khalatepradnya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khalatepradnya @bettinaheim