[docs] Improve qudit's spec and code comments. #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boschmitt
force-pushed
the
improve_qudit_docs
branch
from
9ae7dc2
to
1c34d91
Compare
boschmitt
requested review from
bettinaheim,
amccaskey and
bmhowe23
as code owners
boschmitt
force-pushed
the
improve_qudit_docs
branch
from
1c34d91
to
df0c06f
Compare
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
| quantum operators. The mechanism for negation is via overloading of | ||
| :code:`qudit<Levels>::operator!()`. | ||
|
|
||
| In library mode, it is the runtime responsibilities to: |
There was a problem hiding this comment.
I see library-mode + MLIR mode as implementation details, and not something we need for this document.
amccaskey
reviewed
Apr 16, 2024
boschmitt
force-pushed
the
improve_qudit_docs
branch
4 times, most recently
from
8eabe47
to
0e9248e
Compare
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
boschmitt
force-pushed
the
improve_qudit_docs
branch
from
0e9248e
to
20509bc
Compare
amccaskey
reviewed
Apr 23, 2024
amccaskey
reviewed
Apr 23, 2024
boschmitt
force-pushed
the
improve_qudit_docs
branch
2 times, most recently
from
dd3d743
to
27e589d
Compare
boschmitt
force-pushed
the
improve_qudit_docs
branch
from
3484671
to
721e2ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at improving the specification of the
qudittype. It defines constraints for such type in a language agnostic way, and them reword the current definition as an explanation of the implementation details of this type in the case of C++.