Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #8028

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Small fixes #8028

wants to merge 2 commits into from

Conversation

rinatxp
Copy link

@rinatxp rinatxp commented May 3, 2023

Some small fixes:

  • using (obj is [type] objType) to get rid of an extra cast
  • using StringBuilder in ToString() methods for more performance

@rejurime
Copy link
Contributor

rejurime commented May 4, 2023

Hi! my 2 cents, I think 21 commits to change 15 files isn't great for commit history, wouldn't it be better to do a PR with a clean history to reflect what you want to change? For example, the same commit message is repeated many times and I don't think that adds value to the story.

@rinatxp
Copy link
Author

rinatxp commented May 4, 2023

Hi! Ty for your advice. I squashed all these commits into one

Copy link
Member

@harry-cpp harry-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like small cleanup of is operator usage, but please revert the StringBuilder usage in ToString methods.

Also don't worry about making too many commits in a PR, the maintainers can easily squash them down during the merge process 😉

@rinatxp
Copy link
Author

rinatxp commented May 4, 2023

No problem, I reverted StringBuilder usage

@@ -6,6 +6,7 @@
using System.Diagnostics;
using System.Runtime.CompilerServices;
using System.Runtime.Serialization;
using System.Text;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed reverting this one.

@mrhelmut
Copy link
Contributor

mrhelmut commented May 5, 2023

These changes are C# 5+ features. We really need to restore the C# 5 check from the ConsoleCheck csproj and re-run it to make sure that none slipped in while it was disabled.

EDIT: reverted, and ran the checks.

@mrhelmut
Copy link
Contributor

mrhelmut commented May 5, 2023

Like I feared, we already merged code that breaks this. I'll track that later to revert those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants