remove-hardwired-symbols-and-triggerItem #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayvank
force-pushed
the
152/remove-hardwired-symbols-and-triggerItem
branch
2 times, most recently
from
9343cc9
to
6fe48fa
Compare
kayvank
force-pushed
the
152/remove-hardwired-symbols-and-triggerItem
branch
from
6fe48fa
to
a8613f5
Compare
|
Cograts on making this compile. Could you try and remove most uses of |
Mikolaj
reviewed
Mar 22, 2022
remove-hardwired-symbols-and-triggerItem
kayvank
force-pushed
the
152/remove-hardwired-symbols-and-triggerItem
branch
from
a8613f5
to
5bfaee3
Compare
kayvank
force-pushed
the
152/remove-hardwired-symbols-and-triggerItem
branch
from
df8be36
to
270c733
Compare
|
The failed CI seem to be doctests. I guess they just need updating. |
|
README tells how to run doctests. It may be easier than finding it in the CI script. |
kayvank
force-pushed
the
152/remove-hardwired-symbols-and-triggerItem
branch
from
270c733
to
4563085
Compare
Issue LambdaHack#152, removing uses of toContentSymbol where possible
kayvank
force-pushed
the
152/remove-hardwired-symbols-and-triggerItem
branch
from
4563085
to
dd995ec
Compare
Mikolaj
reviewed
Mar 27, 2022
Mikolaj
reviewed
Mar 27, 2022
Mikolaj
reviewed
Mar 27, 2022
Mikolaj
reviewed
Mar 27, 2022
Mikolaj
reviewed
Mar 27, 2022
Mikolaj
reviewed
Mar 27, 2022
Mikolaj
reviewed
Mar 27, 2022
| @@ -263,7 +252,7 @@ dropItems t = ([CmdItemMenu, CmdItem], t, dropCmd) | |||
|
|
|||
| descIs :: [TriggerItem] -> Text | |||
| descIs [] = "trigger an item" | |||
| descIs (t : _) = makePhrase [tiverb t, tiobject t] | |||
| descIs _ = makePhrase ["fling", "in-range projectile"] | |||
There was a problem hiding this comment.
I'd rather inline the whole makePhrase ["fling", "in-range projectile"] into projectI, because descIs is also used in applyIK so we can't change it freely.
issue 152, remove all hardwired item symbols as well as of TriggerItem. This commit removes the `flingTs` function before continuing to removing the trigger item. `flingTs` added text to `tiverb` and `tiobject`. For now this commit hardwired these texts in the `Game.LambdaHack.Client.UI.Content.Input` function `descIs`
kayvank
force-pushed
the
152/remove-hardwired-symbols-and-triggerItem
branch
from
5138a46
to
9aec886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove-hardwired-symbols, have not gotten to the the triggeritems yet. All build and test issues resolved.