Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggressive constprop in norm #54523

Merged
merged 1 commit into from
May 20, 2024
Merged

Aggressive constprop in norm #54523

merged 1 commit into from
May 20, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented May 20, 2024

This helps reduce TTFX by not compiling the unused branches.

On nightly,

julia> using LinearAlgebra

julia> A = rand(2,2);

julia> @time norm(A);
  0.445819 seconds (341.96 k allocations: 17.589 MiB, 38.80% gc time, 99.99% compilation time) # v"1.12.0-DEV.558"
  0.162979 seconds (341.23 k allocations: 17.554 MiB, 99.98% compilation time) # This PR

@jishnub jishnub added domain:linear algebra Linear algebra compiler:latency Compiler latency labels May 20, 2024
@dkarrasch dkarrasch merged commit 25227c1 into master May 20, 2024
9 checks passed
@dkarrasch dkarrasch deleted the jishnub/normconstprop branch May 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:latency Compiler latency domain:linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants