Fix checked_pow() perf: BigInts can never overflow, so don't need checked math. #54484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
checked_pow(x::BigInt, y::Integer)
skip directly to^(x,y)
. Same for (Integer, BigInt).This means we're again using the native C implementation for power, instead of interpreting it in julia via repeated multiplications. Thanks to @mcmcgrath13 for discovering the issue.
Before:
After:
Co-authored-by: @mcmcgrath13