Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ 17 fixes #12862

Merged
merged 1 commit into from May 20, 2024
Merged

C++ 17 fixes #12862

merged 1 commit into from May 20, 2024

Conversation

rurban
Copy link

@rurban rurban commented Apr 18, 2024

Fix missing C++17 headers in fw-logs-formatting-options

gcc-14

[ 60%] Building CXX object CMakeFiles/realsense2.dir/src/firmware_logger_device.cpp.o
In file included from /home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.cpp:4:
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:31:42: error: ‘uint32_t’ has not been declared
   31 |             std::string get_thread_name( uint32_t thread_id ) const;
      |                                          ^~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:32:42: error: ‘uint32_t’ has not been declared
   32 |             std::string get_module_name( uint32_t module_id ) const;
      |                                          ^~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.cpp:42:21: error: no declaration matches ‘std::string librealsense::fw_logs::fw_logs_formatting_options::get_thread_name(uint32_t) const’
   42 |         std::string fw_logs_formatting_options::get_thread_name( uint32_t thread_id ) const
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:31:25: note: candidate is: ‘std::string librealsense::fw_logs::fw_logs_formatting_options::get_thread_name(int) const’
   31 |             std::string get_thread_name( uint32_t thread_id ) const;
      |                         ^~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:23:15: note: ‘class librealsense::fw_logs::fw_logs_formatting_options’ defined here
   23 |         class fw_logs_formatting_options
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.cpp:51:21: error: no declaration matches ‘std::string librealsense::fw_logs::fw_logs_formatting_options::get_module_name(uint32_t) const’
   51 |         std::string fw_logs_formatting_options::get_module_name( uint32_t module_id ) const
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:32:25: note: candidate is: ‘std::string librealsense::fw_logs::fw_logs_formatting_options::get_module_name(int) const’
   32 |             std::string get_module_name( uint32_t module_id ) const;
      |                         ^~~~~~~~~~~~~~~
/home/rurban/librealsense/src/fw-logs/fw-logs-formatting-options.h:23:15: note: ‘class librealsense::fw_logs::fw_logs_formatting_options’ defined here
   23 |         class fw_logs_formatting_options
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/realsense2.dir/build.make:1266: CMakeFiles/realsense2.dir/src/fw-logs/fw-logs-formatting-options.cpp.o] Error 1

@sysrsbuild
Copy link

Can one of the admins verify this patch?

@Nir-Az
Copy link
Collaborator

Nir-Az commented May 12, 2024

Thanks for the PR,
Closed and re-opened to trigger CI.
Can you add the compiler you use and error you get?

@Nir-Az Nir-Az requested a review from OhadMeir May 12, 2024 05:38
@Nir-Az Nir-Az merged commit 7d70431 into IntelRealSense:development May 20, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants