Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload status_type on @reloadskilldb #3296

Merged
merged 1 commit into from
May 24, 2024

Conversation

jasonch35
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Make @reloadskilldb to load status types for skills that doesn't have StatusChange info in skill_db.conf such as the spirit skills.

Issues addressed: #3295

Copy link
Member

@guilherme-gm guilherme-gm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Just asking one small change regarding this comment.

The fix looks good to me, also in-game tested it and the bug is solved.

src/map/status.c Outdated Show resolved Hide resolved
src/map/status.c Outdated Show resolved Hide resolved
@skyleo
Copy link
Contributor

skyleo commented May 19, 2024

Should be squashed before merging. As accidentally added lines were removed without mentioning.

Moved comment to function
Removed unwanted lines
@skyleo skyleo merged commit e5aefbf into HerculesWS:master May 24, 2024
354 of 357 checks passed
@MishimaHaruna MishimaHaruna added this to the Release v2024.05 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants