Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration to fullprotect skill #2331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carloshenrq
Copy link
Contributor

Changes Proposed

Today, the equip protect status (SC_PROTECTWEAPON, SC_PROTECTHELM, SC_PROTECTARMOR, and SC_PROTECTSHIELD) only apply if there's equip on a respective slot.

Old days, the protect status, apply without the test. So, protect shield work with no shield equip. This PR creates a config that allows going back old days =]

Issues addressed:
There is no issues

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@4144
Copy link
Contributor

4144 commented Nov 27, 2018

Here you have issue with parentheses.
See travis error reports

src/map/battle.h Outdated Show resolved Hide resolved
src/map/skill.c Outdated Show resolved Hide resolved
src/map/status.c Outdated Show resolved Hide resolved
@carloshenrq carloshenrq force-pushed the config_fullprotect branch 2 times, most recently from 5c65625 to 515aef1 Compare November 29, 2018 13:54
conf/map/battle/skill.conf Outdated Show resolved Hide resolved
src/map/skill.c Outdated Show resolved Hide resolved
src/map/status.c Outdated Show resolved Hide resolved
src/map/status.c Outdated Show resolved Hide resolved
src/map/status.c Outdated Show resolved Hide resolved
src/map/status.c Outdated Show resolved Hide resolved
If active, should replace strip status and add new one protected
@Emistry
Copy link
Member

Emistry commented Dec 14, 2018

instead of having 1 or 0 to set the configuration, why not create it as a bitmask value that allow different type of combination depend on user need? It would allow much better customization that user may need?
Ex:

1 - Enable for Strip Helm Skill
2 - Enable for Strip Armer Skill
4 - Enable for Strip Shoes Skill
8 - Enable for Strip Weapon Skill
16 - Enable for Strip Accessory Skill
32 - Enable for FCP Skill
etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants