Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ scan zips before loading #396

Open
wants to merge 3 commits into
base: 4.x
Choose a base branch
from

Conversation

KANAjetzt
Copy link
Collaborator

@KANAjetzt KANAjetzt commented Apr 19, 2024

Optional scanning feature for mod ZIP files before they are loaded into the game.

Please note:
This feature is not a security measure. It simply scans gd and tscn files for specific disallowed strings.


Changes include:

  • New Function: _ModLoaderFile.scan_zip(zip_path: String)

    • Scans a ZIP file for disallowed content.
    • Returns true if disallowed content is found, false otherwise.
  • New ml_options Variables with default values:

    • enable_mod_scan
    • disallowed_strings_in_script_files
    • disallowed_strings_in_scene_files
    • allowed_file_extensions
  • enable_mod_scan is disabled by default to avoid increasing loading times and potentially restricting the scope of modding.

@KANAjetzt KANAjetzt added enhancement New feature or request 4.x labels Apr 19, 2024
@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Apr 19, 2024
@KANAjetzt KANAjetzt requested review from Qubus0, otDan and a team April 19, 2024 19:58
@KANAjetzt KANAjetzt self-assigned this Apr 19, 2024
Provides the option to scan the mod zips before they get loaded into the game and can execute code.
to make it more clear that all that happens is a simple search for keywords.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant