refactor: ♻️ Changed disabled_mods setting to load metadata
#394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KANAjetzt
added
enhancement
5 tasks
otDan
reviewed
Apr 18, 2024
| ## Mods in this array will only load metadata but will not apply any modifications. | ||
| ## This can be used to deactivate example mods. | ||
| ## Mods in this array are overridden by the settings in the user profile. | ||
| @export var deactivated_mods: Array[String] = [] |
There was a problem hiding this comment.
why are we changing it to deactivated? seems like a pointless breaking change?
There was a problem hiding this comment.
I thought about adding a "disabled" and "deactivated" setting first, one to keep the current behavior and one for this change.
I'm not sure what is more accurate.
I don't worry too much about breaking changes for 4.x-v7.
There was a problem hiding this comment.
deactivated makes more sense to me, so i think the rename is fine. but yes, this is breaking and no we can't overlook that anymore since we have windowkill now which relies on it. so we need a proper deprecation both for that and for mod_configs
There was a problem hiding this comment.
unless it's not directly used, then we are fine
KANAjetzt
force-pushed
the
feat_deactivate_mods_setting
branch
from
1ab1f4a
to
48d501c
Compare
- Renamed `disabled_mods` to `deactivated_mods`. - Moved default profile creation in `mod_loader.gd` from `_ready()` to `_load_mods()`. This is required so mod configs can be loaded on the first run of the game. - Separated loading of mod manifests and mod configs to allow the creation of the default user profile in between. - Demoted "No profile" error from error to info because on the first run of the game, the file will not be there. - Fixed the `LOG_NAME` of `_ModLoaderPath`. - Changed the `MOD_CONFIG_DIR_PATH` from `"user://configs"` to `"user://mod_configs"` to make it clearer what kind of configs are stored. - Fixed an issue where `current_config` is `null` because it didn't get set in `ModData._load_config`.
KANAjetzt
force-pushed
the
feat_deactivate_mods_setting
branch
from
48d501c
to
cea915e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabled_modstodeactivated_mods.mod_loader.gdfrom_ready()to_load_mods(). This is required so mod configs can be loaded on the first run of the game.LOG_NAMEof_ModLoaderPath.MOD_CONFIG_DIR_PATHfrom"user://configs"to"user://mod_configs"to make it clearer what kind of configs are stored.current_configwasnullbecause it wasn't set inModData._load_config.