-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Self setup missing global classes #385
base: 4.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these the same as for godot 3? or more?
not everything is the same I believe which is why I have not pushed it to 3.x yet, will have to check better tomorrow |
@@ -51,7 +101,7 @@ const new_global_classes := [ | |||
"language": "GDScript", | |||
"path": "res://addons/mod_loader/api/mod.gd" | |||
}, { | |||
"base": "RefCounted", | |||
"base": "Reference", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't Reference
3.x and RefCounted
4.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh strange I did not get any issues when running it with reference for a 4.x game, I'll check again later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like I was testing with a 3.x game 🤦🏻
Mentioned in #373