feat: Add rename_profile() to ModLoaderUserProfile

[kyooosukedn]

closes #287

Hi, for this change I modified and reference myself to method create_profile as @KANAjetzt in https://github.com/GodotModding/godot-mod-loader/blob/development/addons/mod_loader/api/profile.gd :)

[KANAjetzt]

Thanks for your PR! Let me know if you have any questions or if something is unclear.

[kyooosukedn]

@KANAjetzt Thank you very much for your review, now I think I have corrected the changes the way you suggested. Question for "running modloader in godot" do I need to take the mod developer route to test it?

[KANAjetzt]

For starters, you can create an empty Godot Project and follow the steps on this page.

If you get this working, you can look into symlinking the addons directory into this project.

That will allow you to edit the code inside Godot, where you will get some syntax errors to fix.

If no compile errors show up anymore, you can look into the mod developer route and add the rename functionality to the example user profile UI mod.

This would be ideal, but it might be a bit overwhelming if you've never used Godot. So feel free to just edit your code inside Godot to get the syntax error messages, and I will review your code again.

[kyooosukedn]

Hi @KANAjetzt sorry that it took so long, i corrected some changes as I am able to get the syntax error now

[KANAjetzt]

Almost there - thanks for your work! 👍
As I said in the review, it's important to test things in practice. I added the rename feature to the example UI mod and found the mentioned issues.

[KANAjetzt]

Suggested change

	var profile_to_rename = ModLoaderStore.user_profiles[old_profile_name].duplicate(true)
	var profile_renamed := ModLoaderStore.user_profiles[old_profile_name].duplicate() as ModUserProfile

I only figured this out because I implemented this function in the UserProfileUI mod - so its always a good idea to test your code in practice 😃

[KANAjetzt]

I renamed it from profile_to_rename -> profile_renamed - I feel like this is more clear because it is the reference to the renamed profile.

[KANAjetzt]

I also realized that we are duplicating a Resource here, and that comes with some caveats (here are the Docs).

I added the as ModUserProfile to cast the type. Without that, it's just a generic Resource, and set_profile(profile_renamed) will not work. In addition, I had to change mod_user_profile.gd. As described in the docs, only exported properties are duplicated, so I added the two export to the file:

export var name := ""
export var mod_list := {}

[KANAjetzt]

Suggested change

	# Set it as the current profile
	if ModLoaderStore.current_user_profile == ModLoaderStore.user_profiles[old_profile_name]:
	ModLoaderStore.current_user_profile[new_profile_name]
	# Set it as the current profile if it was the current profile
	if ModLoaderStore.current_user_profile.name == old_profile_name:
	set_profile(profile_renamed)

We can't check for ModLoaderStore.user_profiles[old_profile_name] because it got erased a few lines above.

[kyooosukedn]

Thank you again :) I'm sorry I don't have the chance yet to really dive deep into it..