[core,caps] Allow invalid TS_GENERAL_CAPABILITYSET::protocolVersion

[akallabeth]

some FreeRDP versions did send an invalid value of 0x0000 instead of the required 0x200. Log this kind of violation but continue.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[freerdp-bot]

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11998/

[akallabeth]

@freerdp-bot test

[akallabeth]

@freerdp-bot test again please

[freerdp-bot]

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11999/

[akallabeth]

@freerdp-bot test please

[freerdp-bot]

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/12000/

[hardening]

Looks ok for me, in rdp_write_general_capability_set we should also ignore the value from the settings and always send TS_CAPS_PROTOCOLVERSION.

[akallabeth]

@freerdp-bot test
@hardening hmm, you mean removing the setting?

[freerdp-bot]

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/12001/

[hardening]

@hardening hmm, you mean removing the setting?

I guess that at end that what we will do. But in the meantime that would prevent behaviors like in proxies where you have front settings that you copy as is for the back connection. And so if an old FreeRDP connects front you will fail to connect back because of the check in the write function. Another possibility is to not store the value in the settings when reading the capability set...

[akallabeth]

@freerdp-bot test please

[freerdp-bot]

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/12002/

[akallabeth]

@freerdp-bot test please

[freerdp-bot]

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/12003/

[akallabeth]

@freerdp-bot test please

[freerdp-bot]

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/12004/