Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Protect inputs from autofill #3980

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented May 17, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add autocomplete='one-time-code' to the Input component to address this issue

How did you test this code?

  • Click some input Field

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:29pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:29pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:29pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label May 17, 2024
@novakzaballa novakzaballa linked an issue May 17, 2024 that may be closed by this pull request
@novakzaballa novakzaballa requested review from a team and kyle-ssg and removed request for a team May 17, 2024 22:28
Copy link
Contributor

github-actions bot commented May 17, 2024

Uffizzi Ephemeral Environment deployment-51945

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/3980

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@matthewelwell
Copy link
Contributor

@novakzaballa the description of this PR needs much more context please!

@novakzaballa
Copy link
Contributor Author

@novakzaballa the description of this PR needs much more context please!

@matthewelwell The issue is linked to this PR, nevertheless, I'll also include the link in the PR description

@matthewelwell matthewelwell requested a review from khvn26 May 21, 2024 09:22
@matthewelwell
Copy link
Contributor

I've requested a review from @khvn26 to see if he can still reproduce the issue he raised in #3969.

@khvn26
Copy link
Member

khvn26 commented May 23, 2024

This works as expected, but I'd like to wait to see what @kyle-ssg has to say about this:

  1. This solution is technically a hack: we're accommodating for Chromium ignoring the standards.
  2. Not sure if we want to apply it to every input we have; perhaps an override for the email/login field is in order.

@novakzaballa novakzaballa added the Flagsmith Flag The Issue/PR has a linked feaature flag in Flagsmith label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flagsmith Flag The Issue/PR has a linked feaature flag in Flagsmith front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protect inputs from autofill
3 participants