Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 1:many KeyValueTags #732

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Lothsahn
Copy link

@Lothsahn Lothsahn commented Aug 14, 2023

Add support for 1:many KeyValueTags in Facepunch Items.

Note: This breaks backwards compatibility for existing clients that might be using this functionality. They'll have to retrieve the first item from the list instead. However, I think this is acceptable because:

  1. The current implementation has undefined behavior if there are multiple values for the same key. One of them is returned--which one is based on the order provided by Steamworks, which is not specified in the API
  2. This makes Facepunch match the Steamworks implementation
  3. Given this code is not currently in any released binaries--it's only available for people who have manually built from source--the backwards compatibility impact seems low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant