IR-2012 Update file system operation to promise API (Partial) #10189
Conversation
|
Thank you for your pull request and welcome to the Ethereal Engine developer community! We require contributors to sign our Copyright Assignment Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the agreement at https://forms.gle/15ENsSAJGKf2ozvB7 The agreement has not been signed by users: @jonathan-casarrubias. After signing the agreement, you can ask me to recheck this PR by posting |
jonathan-casarrubias
force-pushed
the
jc/ir-212
branch
from
1a8dc1e
to
95f64ee
Compare
|
Thank you for your pull request and welcome to the Ethereal Engine developer community! We require contributors to sign our Copyright Assignment Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the agreement at https://forms.gle/15ENsSAJGKf2ozvB7 The agreement has not been signed by users: @jonathan-casarrubias. After signing the agreement, you can ask me to recheck this PR by posting |
|
@cla-bot check |
|
Checking that all contributors to this PR are verified. |
jonathan-casarrubias
force-pushed
the
jc/ir-212
branch
5 times, most recently
from
0b4dc12
to
c13be94
Compare
jonathan-casarrubias
force-pushed
the
jc/ir-212
branch
4 times, most recently
from
f0c2db2
to
1351815
Compare
jonathan-casarrubias
force-pushed
the
jc/ir-212
branch
8 times, most recently
from
cb4fb1e
to
c0eda70
Compare
jonathan-casarrubias
force-pushed
the
jc/ir-212
branch
2 times, most recently
from
6c6e914
to
b4dbfaa
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jonathan-casarrubias
force-pushed
the
jc/ir-212
branch
from
b4dbfaa
to
3a6688b
Compare
jonathan-casarrubias
force-pushed
the
jc/ir-212
branch
2 times, most recently
from
4eb3542
to
6232086
Compare
…e non blocking - Introduced writeFileAsync - Introduced cpAsync - Introduced existsAsync - Updated getFilesRecursive - Removed any sync helper - Replaced custom deleteRecursive call in favour of fpd.rm
jonathan-casarrubias
force-pushed
the
jc/ir-212
branch
from
6232086
to
3df0fef
Compare
|
Looking good now, I would like this QA'd on a deployment to make sure the builder and project installer works correctly |
Seemed to all work fine on QAT. |
|
converted to a draft just while it doesnt have checks passing |
Summary
Due the extensive use of file system operations I decided to approach this story by sending portions of each fs api migration with the objective of avoiding extensive and overwhelming code reviews as well as to reduce risk.
For this pull request I introduced writeFileAsync, existsAsync and deprecated deleteFolderRecursive.
I have completely replaced any writeFileSyncRecursive call for the new writeFileAsync.
I have completely replaced any deleteFolderRecursive call for the native node.js api fps.rmdir(path, { recursive: true })
I have partially replaced some fs.existsSync calls for the new existsAsync function, will continue replacing these calls in subsequent PRs
Subtasks Checklist
[x] Implement non-blocking writeFileAsync helper
[x] Implement non-blocking existsAsync helper
[x] Implement non-blocking cpAsync helper
[x] Replace deleteFolderRecursive helper in favour of native non-blocking fps.rmdir function
Breaking Changes
N/A
References
JIRA Ticket IR-2012
QA Steps
Already modified tests using new non-blocking APIs should still pass
npm run test