-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IR-2053] Unit Tests: Core All ECS Hooks/Reactors #10185
[IR-2053] Unit Tests: Core All ECS Hooks/Reactors #10185
Conversation
As per review: - Leftover console.log calls removed - InitialValue checks swapped with `undefined` and a `counter` variable For Types readability: - Change type casts to use a `ResultType` that unions undefined with the expected returned type
Has conflicts @heysokam. Though I'm not sure how they got there since this PR creates the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary approval. Still pending integration with @speigg tests he wrote for immedieteUseEffect.
@DanielBelmes Should be good to go now ✍️ |
* dev: Various Studio Bug Fixes (#10323) fix audio and media node editors (#10338) ability to drag drop in viewport and from asset panel (#10336) Michael/ir 1983 registry - Post Processing and Highlight (#10313) Updated Twitter/Facebook naming to X/Meta (#10065) fix thumbnail generation not proceeding for images and videos remove url from resources.json serialization Fix Thumbnail Generation (#10319) fixing minification warnings and fixing profile button style (#10340) Fix Image Compression Settings (#10283) IR-2532: Update Checkbox UI (#10322) remove extra transactions (#10331) IR-2225 Asset Loading Tech Debt (#10296) feat(assets): update styles [IR-2272] (#10318) Removed font.css, replaced with meta tag imports in components (#10328) background important (#10325) Fix Minio dimage failures (#10333) [IR-2053] Unit Tests: Core All ECS Hooks/Reactors (#10185) [IR-2057] Unit Tests: Hierarchy `EntityTree.tsx` (#10174)
Summary
useAllComponentsSubtasks Checklist
Breaking Changes
References
QA Steps