UVOL Refactor #10085
Merged
UVOL Refactor #10085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CITIZENDOT
force-pushed
the
uvol-refactor
branch
from
5e2fa9e
to
e55b399
Compare
CITIZENDOT
force-pushed
the
uvol-refactor
branch
from
3657024
to
943a255
Compare
…ine into uvol-refactor
Dispose them properly after every track/change in track
Latest hookstate doesn't allow to modify state through proxy
DanielBelmes
requested changes
May 21, 2024
There was a problem hiding this comment.
- None of the node editors(new Uvol and Playlist) are updating snapshots/authoring layer so they are not being saved.
- Can't remove playlist component for some reason. No errors
- Changing playlist playmode is erroring (
TypeError: Cannot set properties of undefined (setting 'playMode') in EditorControlFunctions).
Other than those. Playback looks good
|
Fixed these. But PlaylistComponent is supposed to be set on the VolumetricComponent at all times. Should we enforce it somehow? May be, deny remove when Volumetric is set on the entity? |
DanielBelmes
approved these changes
May 31, 2024
MbfloydIR
added a commit
that referenced
this pull request
Jun 4, 2024
* dev: (56 commits) fixing i18n string configuration for new studio editor on MountPoint (#10308) adding inputRef argument to StringInputProps and StringInput element for new studio. adding auto-focus for search field in elementList/index.tsx (#10306) Updated verify project permission hook to look for context.id as well Updated onSubmit type for confirm dialog to include void Add uniform scaling UI and fix collider resizing (#10302) cleanup unused imports and fix styling in panel layout (#10291) IR-1293 click to select mesh objects in scene edit mode (#10300) Ir 2392 MUI regression (#10301) UVOL Refactor (#10085) fix prototype changes losing material uuids (#10298) recommit changes (#10271) Update email regex to more accurate one (#10284) fix model transform in model component editor (#10235) Updated Cloudfront function to pass most things as routes (#10234) IR-2365 Fix erroneous material updates and prototype switching errors (#10287) fix material renaming (#10297) fix the white lines appearing between panels in studio (#10294) IR-1922 file processing bug on drag/drop (#10285) Add File Browser Search (#10272) fix old collider component reactivity (#10281) ... # Conflicts: # packages/editor/src/components/element/ElementList.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps
PlaylistComponent ⬆️