Fetch relative assets from base_path
instead of root when base_path
is set
#2403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also ran into #2285, and went ahead and had a look. Turns out #2381 fixed most of it, but I believe it needs a trailing
/
in order to serve assets correctly. Without a trailing/
, assets that are relatively addressed will search in the root path instead of relative to thebase_path
, causing 404s as assets are (correctly) served from thebase_path
.This seems as if it was the intended use of
Router::nest
as requests to/<base_path>
are redirected to/<base_path>/
automatically.The alternative would be to hardcode the
base_path
in the assets but I don't think this is a very intuitive approach.